Sorry, but wouldn't the above approach give you a TTC (Through the Cycle) PD, whilst for ECL you're supposed to use the PIT (Point in Time) approach?
Depends upon how one designs the estimation sample. After all, estimation needs to be done for retail portfolios for which no CDS spread is available